[Bug 226503] Merge Review: tree
bugzilla at redhat.com
bugzilla at redhat.com
Sun Feb 4 16:25:37 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: tree
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503
ruben at rubenkerkhof.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|ruben at rubenkerkhof.com |twaugh at redhat.com
CC| |ruben at rubenkerkhof.com
Flag|fedora-review? |fedora-review-
------- Additional Comments From ruben at rubenkerkhof.com 2007-02-04 11:25 EST -------
Hi there,
Review for release 5:
* RPM name is OK
* Source tree-1.5.0.tgz is the same as upstream
* Builds fine in mock
* File list looks OK
Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
(wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
(wiki: PackagingGuidelines#RelocatablePackages)
* Spec file: some paths are not replaced with RPM macros
(wiki: QAChecklist item 7)
* The package should contain the text of the license
(wiki: Packaging/ReviewGuidelines)
Just add LICENSE from the source to %doc
* Preserve timestamps when you install files
Rpmlint is not silent:
Source RPM:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
W: tree hardcoded-prefix-tag /usr
W: tree hardcoded-path-in-buildroot-tag /var/tmp/tree-root
rpmlint of tree:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list