[Bug 225875] Merge Review: gtksourceview

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gtksourceview


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225875


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|roozbeh at farsiweb.info       |rstrode at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-04 11:48 EST -------
Initial comments:
* The README file mentions different version requirements than in the spec file:
"GtkSourceView requires GTK+-2.8.x, libxml2 2.5.x and libgnomeprint 2.8.x."

So you should change gtk2_version to 2.8.0, have a libgnomeprint_version macro
that says 2.8.0 also and change the present 2.7.1 requirements to use that
instead, and perhaps also add a versioned requirement for libxml2-devel (2.5.0).

* The description and the summary fields are only different in one word
("with"). Please add more description to the description field.

* Give full URL of the tarball in the Source0 line.

* Use "make %{?_smp_mflags}" instead of "make" in %build.

* There is an empty %doc line in the files section. Include at least AUTHORS,
ChangeLog, COPYING, NEWS, and README. (blocker)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.