[Bug 226329] Merge Review: pycairo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: pycairo


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226329


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mbarnes at redhat.com
                 CC|                            |roozbeh at farsiweb.info
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-04 15:29 EST -------
Random notes:
* Change URL to: http://cairographics.org/pycairo
* Add complete URL for "Source:"
* Use full BuildRoot of
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* No need to BuildRequires on python, python-devel pull that
* Use make %{?_smp_mflags} instead of make
* Use %{name} in Requires: %name = %{version}-%{release} (style)
* Don't use %makeinstall, but make DESTDIR=$RPM_BUILD_ROOT install
* Change 'xargs rm' to 'xargs rm -f'
* The %doc line is empty. At least ship ChangeLog, README, AUTHORS, COPYING*,
and NEWS. Perhaps also NOTES (in main package or -devel, don't really know).
* -devel package should Require pkgconfig
* Change this:
    %dir %{_includedir}/pycairo
    %{_includedir}/pycairo/pycairo.h
  to this:
    %{_includedir}/pycairo/


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.