[Bug 227291] Review Request: ptunnel - Reliably tunnel TCP connections over ICMP packets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ptunnel - Reliably tunnel TCP connections over ICMP packets


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227291





------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-04 18:07 EST -------
Not an official review because you need a sponsor, which I am not.

- rpmlint is silent on both src.rpm and generated rpm [1]
- package meets naming guidelines (upstream calls the project "Ping Tunnel",
refers to it as "ptunnel" and packages it as "PingTunnel-release.tar.gz").
- package meets packaging guidelines
- license (BSD) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, sha1sum cea9c16fa4da0af2f59f2ece7ede56650095a752 
PingTunnel-0.61.tar.gz
- package builds on devel (x86_64) [1}
- MUSTFIX: missing BR libpcap-devel
- MUSTFIX: unnecessary BR libpcap
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of foreign
 files/directories
- MUSTFIX: duplicate file ptunnel.8.gz
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file since the program is just command line
- no static, .la, .pc
- no scriptlets

 [1] with corrected BR
 [2] the %files section could be rewritten as
%files
%defattr(-,root,root,-)
%doc CHANGELOG LICENSE README web/
%{_bindir}/ptunnel
%{_mandir}/man8/ptunnel.8*


SHOULD
- with corrected BR, builds in mock
- runs as advertised


Please correct the above mentioned MUSTFIX and once you find a sponsor, you
should point him to this pre-review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.