[Bug 225979] Merge Review: lam

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: lam


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225979





------- Additional Comments From ed at eh3.com  2007-02-04 22:54 EST -------
Please ignore (and, if possible, excuse) comment #2.  I've read through 
both the LAM and OpenMPI spec files and quite a bit has happened in the 
past 6+ months.  Here is the start of a more thorough review--I'm just 
too tired to continue tonight and will post what I have so far:

good:
 + license is good and correctly included
 + spec file is not needlessly complicated (!)
 + proper handling of ldconfig

standing on a soap-box preaching to... somebody, hopefully:
 + I applaud the folks who put the time and effort into making 
   LAM and OpenMPI work with (and hopefully, without) the 
   "alternatives" system.  Unfortunately, I think its the wrong
   way to solve the problem.  Unlike the selection of an MTA, 
   the selection of an MPI system is NOT (and should NOT!) be 
   treated as a system-wide affair.  In an ideal world, users 
   should be able to effortlessly switch between different 
   MPI implementations at any time.  For different MPI 
   implementations, using something like the "environment 
   modules" approach makes a *LOT* more sense than the 
   "alternatives" system (which is geared towards programs
   which are much more system-wide and much less able to 
   work independently and simultaneously).

needswork or "please help me understand this":
 - Source should match upstream.  It appears that the only 
   differences between the supplied '7.1.2-rh1' tarball and 
   the upstream '7.1.2' is the removal of some code covered
   by the APPLE PUBLIC SOURCE LICENSE v2 which, according to:

http://fedoraproject.org/wiki/Packaging/Guidelines#Legal

   is OK to include in Fedora.  But perhaps there are some 
   more complicated linkage issues that necessitate its 
   removal...?  Could you please explain.

 - rpmlint output is available at:
http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/lam-7.1.2-8.fc7.src.rpm/result/rpmlint.log
   and most of it seems to be cosmetic (e.g. the trailing '.' and the 
   macro-in-changelog entries).  However, the dangling-relative-symlink
   warning does seem worrisome.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.