[Bug 227256] Review Request: moto4lin - Filemanager and seem editor for Motorola P2k phones

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: moto4lin - Filemanager and seem editor for Motorola P2k phones


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227256





------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-05 01:57 EST -------
The package looks almost fine now, except for
- in Fedora there is no lib64usb-devel. Independent of architecture the package
is called libusb-devel.
- the Categories section in the .desktop does not look right. I for one would
not look for this app under "Graphics" but under "Communications" or something
similar. Maybe that, for inspiration sake, you could take a pick at some other
similar application ?
- patches are to be included as %Patch, not as %Source. I suggest

-Source3:        %{name}-0.3-crossplatform.patch
+Patch:          %{name}-0.3-crossplatform.patch
-patch -p1 -s <%{SOURCE3}
+%Patch -p1 -b crossplatform

Please address the above and I will be glad to do a final review.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.