[Bug 225652] Merge Review: comps-extras

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: comps-extras


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225652


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |katzj at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-05 10:26 EST -------
rpmlint output:
W: comps-extras no-url-tag
W: comps-extras no-documentation

(Assumed fine)

Random notes:
* Consider changing the buildroot to
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* URL should be provided for upstream tarball at least, to check against (MUST item)
* GPL may not be a very appropriate license for a set of PNG images
* Change make to "make %{?_smp_mflags}"
* Change %defattr(-,root,root) to %defattr(-,root,root,-)
* Packages puts files in /usr/share/pixmaps without owning that directory or
depending on any packages that owns it (blocker).
* Better add extra slash at the end of %{_datadir}/pixmaps/comps to show it's a
directory: %{_datadir}/pixmaps/comps/


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.