[Bug 226316] Merge Review: privoxy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: privoxy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226316





------- Additional Comments From paskalis at di.uoa.gr  2007-02-05 10:35 EST -------
The privoxy spec is borrowed from upstream with many legacy conventions that it
makes it very hard to read and possibly maintain.

Some examples:
- There are some lines that remove carriage returns from configuration files,
although no such action is necessary with the last privoxy version (3.0.6).
Moreover they are really hard to parse.  Example:

for i in `ls *.action`
do
       cat $i | sed -e 's/[[:cntrl:]]*$//' > %{buildroot}%{privoxyconf}/$i
done

- There are many lines dealing with previous names of the package, namely
junkbuster and/or junkbust.  The rename happened about 6-7 years ago, so I think
it is safe to drop this legacy compatibility stuff.

- There are too many consistency checks, such as:
  * consistency between versions in specfile and configure file.
  * consistency between user/group id in the system and user/group id specified
   in the specfile
The privoxy package has remained in this state for the last 6-7 years, so I
suppose it is safe to drop these consistency checks.

- As for the used uid/gid pair, I asked in the fedora-packaging list about the
hardcoded paths, and the answer was that it is ok to keep using them as long as
they are documented in /usr/share/doc/setup-*/uidgid.  Privoxy is (documented),
so it is ok to hardcoded uid,gid=73,73.

- There are some comments in the top of the spec file that only clutter the
readability.

- Buildroot is not according to the fedora guidelines

Since I was some time ago involved in upstream, I tried to clean up the spec
file and follow as close as possible the packaging guidelines.

Specfile and SRPM can be found at:
http://gallagher.di.uoa.gr/any/rpms/privoxy/privoxy.spec
http://gallagher.di.uoa.gr/any/rpms/privoxy/privoxy-3.0.6-3.src.rpm

There are some other issues in the spec file, such as disabling dynamic pcre and
using a static copy, but I did not touch them to keep the functionality as close
to current as possible.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.