[Bug 225624] Merge Review: booty

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: booty


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225624


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pjones at redhat.com
                 CC|                            |roozbeh at farsiweb.info
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-05 10:49 EST -------
rpmlint output:
  RPM:
W: booty summary-not-capitalized simple python bootloader config lib
W: booty no-url-tag
E: booty only-non-binary-in-usr-lib
E: booty non-executable-script /usr/lib/booty/checkbootloader.py 0644
E: booty non-executable-script /usr/lib/booty/lilo.py 0644
E: booty non-executable-script /usr/lib/booty/grubupdatetest.py 0644
  SRPM:
W: booty summary-not-capitalized simple python bootloader config lib
W: booty no-url-tag
E: booty hardcoded-library-path in /usr/lib/booty

Other problems:

* License filed says LGPL, while the file lilo.py in the package is actually
labeled GPL in the header. (blocker)
* No copy of either GPL or LGPL is provided in tarball or is packaged.
* Use make %{?_smp_mflags} instead of make
* /usr/lib is hard-coded. Use a pref-defined rpm macro instead. (blocker)
* Change %defattr(-,root,root) to %defattr(-,root,root,-)
* Change buildroot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Validity of tarball couldn't be checked, as no upstream is mentioned either as
URL or Source URL. (blocker)
* We no longer have up2date, so its mention should be removed from description.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.