[Bug 226491] Merge Review: time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: time


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226491


ruben at rubenkerkhof.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|ruben at rubenkerkhof.com      |laroche at redhat.com
                 CC|                            |ruben at rubenkerkhof.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From ruben at rubenkerkhof.com  2007-02-05 16:41 EST -------
Hi Florian,

Here's my review for time 1.7 release 28:
* RPM name is OK
* Source time-1.7.tar.gz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
  (wiki: PackagingGuidelines#RelocatablePackages)
* The %makeinstall macro should not be used
  (wiki: PackagingGuidelines#MakeInstall)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)


Notes:
* Use Requires(post) and Requires(preun) instead of Prereq
* Is "echo "ac_cv_func_wait3=\${ac_cv_func_wait3='yes'}" >> config.cache" still needed?
  the configure script detects wait3 without it as well (at least, on FC-6)


Rpmlint is not silent:

Source RPM:
W: time summary-ended-with-dot A GNU utility for monitoring a program's use of system resources.
W: time no-url-tag
W: time redundant-prefix-tag
W: time prereq-use /sbin/install-info
W: time mixed-use-of-spaces-and-tabs (spaces: line 39, tab: line 34)

rpmlint of time:
W: time summary-ended-with-dot A GNU utility for monitoring a program's use of system resources.
W: time no-version-in-last-changelog
W: time no-url-tag


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.