[Bug 227256] Review Request: moto4lin - Filemanager and seem editor for Motorola P2k phones

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: moto4lin - Filemanager and seem editor for Motorola P2k phones


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227256





------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-05 21:40 EST -------
Just checked the new version. These seem to be the problems left:
- Since release 3, you do not use a consistent convention for the Buildroot.
Please select either $RPM_BUILD_ROOT or %{buildroot} and use it everywhere
(http://fedoraproject.org/wiki/Packaging/Guidelines#UsingBuildRootOptFlags)
- Packaging/Guidelines/Compiler flags is not respected. The build process is
based on qmake.conf default settings, not on $RPM_OPT_FLAGS
- the .desktop file does not use a standard category. Please try to find an
appropriate one from http://standards.freedesktop.org/menu-spec/latest/apa.html
- I am not sure that Applications/File is the proper RPM Group (I feel like
Applications/Communications being more appropriate since you communicate with
the mobile..) but I will not object if you retain it. Maybe someone more
experienced could give us a hint here ?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.