[Bug 225207] Review Request: libsmbios - library for userspace smbios table parsing
bugzilla at redhat.com
bugzilla at redhat.com
Tue Feb 6 03:53:45 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: libsmbios - library for userspace smbios table parsing
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225207
Matt_Domsch at dell.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |Matt_Domsch at dell.com
------- Additional Comments From Matt_Domsch at dell.com 2007-02-05 22:53 EST -------
Created an attachment (id=147432)
--> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147432&action=view)
rpmlint results
MUST:
* name good
* spec name good
* license good
* license matches
* licenses are in %doc for all subpackages
* spec is English
* spec is legible
* sources match
* package builds on mock for i386 and x86_64 at least, didn't try ia64
* comment present for ExclusiveArch
* BRs OK
* no locales used
* ldconfig used in %post and %postun properly
* not relocatable
* package owns its directories
* no duplicate files
* defattr present for each subpackage
* %clean ok
* consistent use of macros
* packages contain code, not content
* extra docs not presently being built, will be in -devel when they
are. No need for a -doc subpackage.
* nothing in %doc needed at runtime
* headers and static libs in -devel package
* no .pc files
* -devel has the unversioned lib*.so files
* -devel properly requires name = %{version}-%{release}
* no GUI -> no .desktop
* no directory ownership problems
SHOULD:
* source includes licenses
* string translations not available
* package builds in mock
* package builds on all supported arches
* package runs as expected
* scriptlets sane
* subpackages properly Require parent
* no pkgconfig files
Packaging Guidelines
* changelog ok
* tags ok
* buildroot ok
* summary and descriptions ok
* encoding ok
* docs ok
* optflags ok
* no static linked bins
* no system lib duplication
* no rpath
* no config files
* no desktop files
* consistent macros
* no %makeinstall
* no locale
* cp -a used
* smp_mflags used
* scriptlets ok
You can ignore the rpmlint error about missing the ldconfig symlink,
as it's present in the -devel package as PackagingGuidelines require.
Bugs:
* Docs permissions are 755, not 644
* source files, thus /usr/src/debug/* are 755, not 644
* package includes *.la files, need to be rm'd in %install and not
installed in %files.
* Obsoletes, but doesn't Provide, a couple packages
* -libs Summary ends with a .
* -devel %doc should include additional licenses of boost (boost
1.0, which is GPL-compatible)
* add getopts (3-clause BSD) license to all %docs
* add a MANIFEST in %doc noting which parts are covered by which
license.
* trivial rpmlint cleanups for spelling and the like
APPROVED with the above trivial fixes
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list