fedora-review denied: [Bug 225895] Merge Review: icon-slicer

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 6 10:38:37 UTC 2007


Bug 225895: Merge Review: icon-slicer
Product: Fedora Extras
Version: devel
Component: Package Review

Roozbeh Pournader <roozbeh at farsiweb.info> has denied Roozbeh Pournader
<roozbeh at farsiweb.info>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225895

------- Additional Comments from Roozbeh Pournader <roozbeh at farsiweb.info>
Random first notes:
* change BuildPrereq to BuildRequires
* change Release to integer value, perhaps also using %{?dist}
* change BuildRoot to
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* License field says MIT, but there is a copy of GPL in the tarball named
COPYING!
* ship at least ChangeLog and AUTHORS in %doc
* use make DESTDIR=$RPM_BUILD_ROOT install instead of %makeinstall
* change %defattr(-,root,root) to %defattr(-,root,root,-)
* use make %{?_smp_mflags} instead of make
* provide URL field
* provide complete URL of source tarball in the Source field




More information about the Fedora-package-review mailing list