[Bug 226357] Merge Review: rdate

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: rdate


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226357


roozbeh at farsiweb.info changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |pknirsch at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From roozbeh at farsiweb.info  2007-02-07 09:39 EST -------
Random first notes:
* Remove the dot at the end of Summary line.
* It seems that there is no upstream. No URL is given, and the Source address
doesn't work either. So I can't check that this is the same as the upstream
source. (BLOCKER)
* Change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Use the option %{?_smp_mflags} for make.
* Don't use %makeinstall, if possible. See
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall
* Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
* Consider using %{?dist} in Release tag.
* The binary file 'rdate' is installed with permission 555 in the Makefile. It
should be 755. This can be fixed either by patching the Makefile or by
explicitly changing the permission in the %install or %files section. (BLOCKER)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.