fedora-review denied: [Bug 226351] Merge Review: qt

[bugzilla at redhat.com]

Bug 226351: Merge Review: qt
Product: Fedora Extras
Version: devel
Component: Package Review

Rex Dieter <rdieter at math.unl.edu> has denied Rex Dieter
<rdieter at math.unl.edu>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226351

------- Additional Comments from Rex Dieter <rdieter at math.unl.edu>
Guidelines-wise, looks good, only a few relatively small SHOULD (optional)
items
to consider:

* icons.  SHOULD try to follow icon-spec here, and put items in/under
%_datadir/icons/hicolor/ somewhere instead of using %_datadir/pixmaps

* .desktop files: using namespace/vendor of qt-* *and* using '3' appended to
.desktop file names is redundant.  Consider removing the '3' from the .desktop
file names.

* consider changing qtdir from %{_libdir}/qt-3.3 to just %_libdir/qt3.	It
would
then be consistent with qt4 packaging.	This is a big change that may induce
pain in other packages that currently hard-code the old location, so it may not

be worth it.

* -devel-docs subpkg SHOULD:
  1. should simply be -doc (corrolary: and have no dependency on -devel)
  2. assistant should be included here.

* SHOULD avoid some of the multilib ickiness, and necessity to use
/etc/ld.so.conf.d/qt*, by simply using
./configure -libdir %{_libdir}
ie, putting qt's libs into %_libdir directly.

qt4 has been using these latter 2 items with success.