[Bug 226411] Merge Review: setserial

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: setserial


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226411


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|163778                      |163779
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-07 12:48 EST -------
Formal review for release 2.17-20.fc7:

- package meets naming guidelines
- package meets packaging guidelines
- license is GPL (hence OK), matches source; upstream does not include the
license, so it isn't included in the package either
- spec file legible, in am. english
- source matches upstream, last available version, sha1sum
68824494a0b5700f7e999564a59358bf34f79eb1  setserial-2.17.tar.gz
- package bilds in mock for devel/x86_64
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all files and directories that it creates, does take not take ownership
of foreign files/directories
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no static, .pc, .la files
- no need for .desktop file
- rpmlint is silent on the source; there is one warning for the generated binary:
W: setserial spurious-executable-perm /usr/share/doc/setserial-2.17/rc.serial
It can be ignored, this is meant as an initscript which ( if needed ) must be
installed in /etc/init.d anyway

SHOULD
- builds cleanly in mock
- runs as advertised

TODO
- upstream should be bugged to included the license in the supplied tar.gz


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.