[Bug 225838] Merge Review: gnome-system-monitor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-system-monitor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225838


dakingun at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|nobody at fedoraproject.org    |dakingun at gmail.com
               Flag|                            |fedora-review-, needinfo?




------- Additional Comments From dakingun at gmail.com  2007-02-07 16:15 EST -------
Good:
* Package name conforms to the Fedora Naming Guidelines
* Sources, Group and License tags properly in place
* Locales handled correctly
* All necessary BuildRequires listed.
* Package builds OK in Mock.

NEEDSWORK:
According to the packaging guildlines on rpm scriplets,
* The post and postun Requires on desktop-file-utils is not necessary
* call to scrollkeeper-update in post section is inclomplete, should be called like;
 "scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :"
* I believe the "add-category X-Redhat-Base" is no longer necessary for the
desktop file install.

A couple of other minor nitpicks;
* You can pass the "--disable-schemas-install" option to the configure script,
without needing to set and unset the GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL env.
* There are a number of rpmlint warnings/errors which I believe can be ignored;
[deji at agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.src.rpm
W: gnome-system-monitor unversioned-explicit-obsoletes gtop
[deji at agape reviews]$ rpmlint gnome-system-monitor-2.17.6-1.fc7.x86_64.rpm
E: gnome-system-monitor obsolete-not-provided gtop
W: gnome-system-monitor no-documentation
W: gnome-system-monitor non-conffile-in-etc
/etc/gconf/schemas/gnome-system-monitor.schemas

 
 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.