fedora-review denied: [Bug 225237] Merge Review: acpid

[bugzilla at redhat.com]

Bug 225237: Merge Review: acpid
Product: Fedora Extras
Version: devel
Component: Package Review

Kevin Fenzi <kevin at tummy.com> has denied Kevin Fenzi <kevin at tummy.com>'s
request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225237

------- Additional Comments from Kevin Fenzi <kevin at tummy.com>
Thanks for the quick fixes and reply... 

1. good. ok. 

2. good. ok. 

3.1 good. ok. 

3.2 I suppose so. ok. 

3.3 good. ok. 

3.4 Not sure why it's complaining about that 0755 init script. ;( 
good on the prereqs. 

3.5 good. ok. 

4.1 Humm...I haven't seen that used for /var/log/FOO files before... I guess
there aren't many packages that make such files. Looking at for example
vixie-cron, it just has no mention of the log file at all. 
I guess the question is: do we want this package to remove the /var/log/acpid
log when the package is removed? Or should it linger around?
We should probibly decide what behavior is desired and make all the packages
that create /var/log files do the same thing... 

In fact I am hard pressed to find another package that does things the way
this one does. Do you have any example? scrollkeeper appears to ghost the log
file, but yum, x.org, vixie-cron just don't claim anything for their log file
(ie, it's unowned). 

4.2 good. ok. 

4.3 good. ok. 

Setting it back to you to comment on the 4.1 issue. 
When you do, please assign it back to me and change the fedora-review flag back

to ? 

Thanks again for the quick fixes...