[Bug 227309] Review Request: seom - Desktop video capture and playback utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: seom - Desktop video capture and playback utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227309





------- Additional Comments From tom at dbservice.com  2007-02-08 04:36 EST -------
(In reply to comment #2)
> * License

added LICENSE (GPLv2)
btw, quicklz is licensed under the GPL, so that shouldn't be a problem.

> 
> * Timestamps

No reason to add '-p' when installing seom.pc, because that file is
auto-generated. But I added '-p' when installing the headers..


-$(CC) $(CFLAGS) $(LDFLAGS) -L.libs -o $@ src/$@/main.c -lseom $($@LIBS)
+$(CC) $(CFLAGS) $(EXTRA_CFLAGS) $(INCLUDES) $(LDFLAGS) -L.libs -o seom-$@
src/$@/main.c -lseom $($@LIBS)

'seom-$@' is ok in the srpm, but when compiling seom from sources more than once
it's bad because then make will recompile the apps every time make is executed..  

and, what's wrong with 'libtool --mode=install'?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.