[Bug 225863] Merge Review: gsl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gsl


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225863


jamatos at fc.up.pt changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jamatos at fc.up.pt
               Flag|                            |fedora-review?




------- Additional Comments From jamatos at fc.up.pt  2007-02-08 09:21 EST -------
I have some suggestions regarding the spec file:

- Use the BuildRoot defined in the guidelines (this is suggested but in no way 
a blocker)

- for gsl-devel require gsl = %{version}-%{release} it is better to be 
safe :-)

 - make %{?_smp_mflags} - it works, I have tested it

 - in %install it is necessary to clean the buildroot and also %makeinstall 
can be replaced with make install DESTDIR=$RPM_BUILD_ROOT, again I have tested 
an it works.

  - finally the file attributes should be %defattr(-,root,root,-)

  There are other issues I would like to search, mainly related with the 
static libraries, but before going there I would like to hear you on these 
changes.

  One final note, a matter of style, I like more the description used in the 
spec file distributed in the tar ball, while the one present in the spec file 
is, maybe, too terse. Again this is a matter of taste so it is in no way a 
blocker.

  I will put in the next entry a patch with these changes...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.