fedora-review granted: [Bug 225819] Merge Review: gnome-keyring

[bugzilla at redhat.com]

Bug 225819: Merge Review: gnome-keyring
Product: Fedora Extras
Version: devel
Component: Package Review

Deji Akingunola <dakingun at gmail.com> has granted Deji Akingunola
<dakingun at gmail.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225819

------- Additional Comments from Deji Akingunola <dakingun at gmail.com>
GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Spec file clean and legible
 * Handles locales appropriately
 * Buildrequires properly listed
 * rpmlint silent/OK (there's an ignorable warning on the -devel subpackages
[deji at agape reviews]$ rpmlint gnome-keyring-devel-0.7.3-1.fc7.x86_64.rpm
W: gnome-keyring-devel no-documentation)
 * Source file matches upstream
4478d21d3ef56a3992411bee7ab6df73  gnome-keyring-0.7.3.tar.bz2

 NEEDSWORK:
 * Complete url to the SOURCE is not provided.

APPROVED.