fedora-review granted: [Bug 225820] Merge Review: gnome-keyring-manager
bugzilla at redhat.com
bugzilla at redhat.com
Thu Feb 8 15:15:13 UTC 2007
Bug 225820: Merge Review: gnome-keyring-manager
Product: Fedora Extras
Version: devel
Component: Package Review
Deji Akingunola <dakingun at gmail.com> has granted Deji Akingunola
<dakingun at gmail.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225820
------- Additional Comments from Deji Akingunola <dakingun at gmail.com>
GOOD:
* Build Ok in mock (x86_64)
* License (GPL) and rpm Group tag OK
* Naming meets the packaging guildlines
* Spec file clean and legible
* Handles locales appropriately
* Buildrequires properly listed
* rpmlint silent on srpm and a warning that can be ignored on the binary
[deji at agape reviews]$ rpmlint gnome-keyring-manager-2.17.0-1.fc7.x86_64.rpm
W: gnome-keyring-manager non-conffile-in-etc
/etc/gconf/schemas/gnome-keyring-manager.schemas
* Source file matches upstream
8dc9c133ccdfb2729898a05afa177a0d gnome-keyring-manager-2.17.0.tar.bz2
NEEDSWORK:
* Complete url to the SOURCE is not provided.
APPROVED.
More information about the Fedora-package-review
mailing list