[Bug 223586] Review Request: strigi - A desktop search program for KDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: strigi - A desktop search program for KDE


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223586





------- Additional Comments From dakingun at gmail.com  2007-02-08 12:28 EST -------
(In reply to comment #1)

> * compiler flags
>   - does not pass fedora specific compilation flags.
Well, i did pass it, but the cmake stuff refused to use it, will check if I can
force it to.

> 
> * conditional dependency
>   - Check:
> ------------------------------------------
> -- Xerces-C was not found.
> ------------------------------------------
Must have missed this one, will fix.
> 
> * desktop file
>   - /usr/bin/strigiclient seems to be a GUI program
>     and desktop file for this program should be added,
>     perhaps.
 No, there's a separate package (stigiapplet), that provides GUI support for
strigi as an applet. It is also integrated with konqueror and can thus
optionally be used from it (using some form of strigi:// protocol)
> 
> * File location
>   - All header files under /usr/include in -devel package
>     should be moved to %{_includedir}/%{name}. From I
>     checked the #include entry, this is no problem and
>     putting header files directly under /usr/include should
>     be avoied.
I don't really understand what you're saying here, but i get the idea, will look
into fixing it.

> * Dependency
>   - Check the dependency for -devel package. I have never
>     checked the header files for Qt4 package. However,
>     /usr/include/strigi/qtdbus/strigidbus.h includes:
> ---------------------------------------------
> #include <QtCore/QByteArray>
> ---------------------------------------------
Strigi also optionally depends on dbus-qt; but at the time I first packaged and
put it up, dbus-qt was not available in fedora (devel) repo. Now that it
(dbus-qt) is available, I'll consider adding it as buildrequire.

>     This means that -devel package should require
>     some Qt4 related packages.
> 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.