[Bug 227811] Review Request: hunspell-af - Afrikaans hunspell dictionary

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-af - Afrikaans hunspell dictionary


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227811


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163779
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-08 13:50 EST -------
Caolan: I am willing to work with you through all dictionaries.

Quick review for this package:
- unzip is not needed as BR because it's on the exception list (see 
http://fedoraproject.org/wiki/Extras/FullExceptionList)
- adding -q to the %setup line and an empty %build would silence rpmlint (see below)

Everything else seems fine
- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum fa0dfbe45efd7eeba04e069f2e5987b721ebae71 
af_ZA-pack.zip
- the package builds in mock, devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- the license LGPL stated in the tag is the same as the web site says
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no .la, .pc, static files
- no missing BR
- MINOR: unneeded BR: unzip
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output:
on source:
W: hunspell-af setup-not-quiet
W: hunspell-af no-%build-section
on binary: silent
- code, not content
- no need for -docs as the only doc is just a 31K text file
- nothing in %doc affects runtime
- no need for .desktop file 

The package is APPROVED but before comitting to CVS please fix the three small
problems mentioned in the first paragraph.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.