[Bug 226105] Merge Review: logwatch

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: logwatch


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226105


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From kevin at tummy.com  2007-02-08 23:20 EST -------
1. Removing them I guess is ok.
Have you contacted upstream about distributing them at all?

2. good. ok.

3.1. %build added ok.

3.2. 644 on all the services looks good. ok.

3.3. The logwatch.pl links are still not relative...
Suggest:

Change:

ln -s %{_datadir}/logwatch/scripts/logwatch.pl
%{buildroot}%{_sysconfdir}/cron.daily/0logwatch
ln -s %{_datadir}/logwatch/scripts/logwatch.pl %{buildroot}%{_sbindir}/logwatch

to

ln -s ../../%{_datadir}logwatch/scripts/logwatch.pl
%{buildroot}%{_sysconfdir}/cron.daily/0logwatch
ln -s ../../%{_datadir}logwatch/scripts/logwatch.pl %{buildroot}%{_sbindir}/logwatch

3.4. The "pix" file still has dos CR/FE endings...
Suggest:

%{__sed} -i 's/\r//' %{buildroot}%{_datadir}/logwatch/scripts/services/pix

3.5. ok.

So, 3.3 and 3.4 are the only outstanding items I see...

Once you have addressed these items (either by making the suggested changes, or
by explaining why they don't make sense), please reassign this review back
to me, and change the 'fedora-review' flag back to ? for me to take action.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.