fedora-review granted: [Bug 226436] Merge Review: statserial

[bugzilla at redhat.com]

Bug 226436: Merge Review: statserial
Product: Fedora Extras
Version: devel
Component: Package Review

manuel wolfshant <wolfy at nobugconsulting.ro> has granted Tim Waugh
<twaugh at redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226436

------- Additional Comments from manuel wolfshant <wolfy at nobugconsulting.ro>
Formal review for release 39:

MUST
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPL ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream, sha1sum 3ace36585c82238003b37f267263f06aad4f0afd 
statserial-1.1.tar.gz
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of
foreign
files/folders
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 
- no static, .la, .pc files
- rpmlint is silent on src.rpm; for the binary the following warnings are
generated:
W: statserial spurious-executable-perm /usr/share/doc/statserial-1.1/phone_log
W: statserial doc-file-dependency /usr/share/doc/statserial-1.1/phone_log
/bin/bash
Since phone_log IS a bash script and bash is supposed to be already installed
anyway, no additional packages are actually pulled so I guess both warnings can

safely be ignored.

SHOULD
- Builds fine in mock for FC6 and devel (x86_64)
- Runs as advertised on FC6/x86_64

Notes:
I have no access to 390 so I can only assume that the hardware being different,

the ExcludeArch is justified.


APPROVED