fedora-review granted: [Bug 225822] Merge Review: gnome-media

[bugzilla at redhat.com]

Bug 225822: Merge Review: gnome-media
Product: Fedora Extras
Version: devel
Component: Package Review

Deji Akingunola <dakingun at gmail.com> has granted Bastien Nocera
<bnocera at redhat.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225822

------- Additional Comments from Deji Akingunola <dakingun at gmail.com>
GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Spec file clean and legible
 * Handles locales correctly
 * Build dependencies properly listed
 * Source file matches upstream's
094a92f01a3581de7b3567f85320df7b  gnome-media-2.17.90.tar.bz2
 * Own its files and directories correctly

rpmlint warnings/error: This can mostly be ignored
[deji at agape reviews]$ rpmlint gnome-media-2.17.90-6.fc7.x86_64.rpm
E: gnome-media obsolete-not-provided gnome
W: gnome-media conffile-without-noreplace-flag
/etc/gconf/schemas/CDDB-Slave2.schemas
W: gnome-media conffile-without-noreplace-flag
/etc/gconf/schemas/gnome-audio-profiles.schemas
W: gnome-media conffile-without-noreplace-flag
/etc/gconf/schemas/gnome-cd.schemas
W: gnome-media conffile-without-noreplace-flag
/etc/gconf/schemas/gnome-volume-control.schemas
[deji at agape reviews]$ rpmlint gnome-media-2.17.90-6.fc7.src.rpm
W: gnome-media unversioned-explicit-obsoletes gnome
[deji at agape reviews]$ rpmlint gnome-media-devel-2.17.90-6.fc7.x86_64.rpm
W: gnome-media-devel no-documentation

However I wonder if it's not just OK to drop that Obsoletes on gnome, it seems
superfluous of gnome-media to Obsolete gnome as it cannot also provide it
(gnome). I believe you can fix that, so

APPROVED.




APPROVED.