fedora-review denied: [Bug 225827] Merge Review: gnome-nettool

[bugzilla at redhat.com]

Bug 225827: Merge Review: gnome-nettool
Product: Fedora Extras
Version: devel
Component: Package Review

Deji Akingunola <dakingun at gmail.com> has denied Deji Akingunola
<dakingun at gmail.com>'s request for fedora-review:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

------- Additional Comments from Deji Akingunola <dakingun at gmail.com>
Hi,

NEEDSWORK:
 * Post and postun requires on desktop-file-utils are not necesary
 * why does it need to run 'update-desktop-database' in it post and postun, the

desktop file deosn't seem to contain any mimetype key (admittedly, I only
checked src/gnome-nettool.desktop.in)
 * The '--add-category X-Red-Hat-Base' can also be removed from the
desktop-file-install, its redundant.
 * Packaging guildelines discourage using the '%makeinstall' macro (see 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbc
fbdd2fcb7791dd002)