[Bug 217654] Review Request: TMDA - Tagged Message Delivery Agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TMDA - Tagged Message Delivery Agent


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217654


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-09 11:02 EST -------
Well, for rpmlint issues:

* spurious-executable-perm
* doc-file-dependency
---------------------------------------------
W: tmda spurious-executable-perm /usr/share/doc/tmda-1.1.9/contrib/printdbm
W: tmda doc-file-dependency
/usr/share/doc/tmda-1.1.9/contrib/update-internaldomains /usr/bin/env
---------------------------------------------
  - You may have confused about these messages, however
---------------------------------------------
$ rpmlint -I spurious-executable-perm
spurious-executable-perm :
The file is installed *with executable permissions*, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

$ rpmlint -I doc-file-dependency
doc-file-dependency :
An included file marked as %doc creates a possible additional dependency in
the package.  Usually, this is not wanted and may be caused by eg. example
scripts *with executable bits set* included in the package's documentation.

-------------------------------------
    so please ensure that %doc files do not have executable
    permissions.

* zero-length
-------------------------------------
E: tmda zero-length /usr/share/doc/tmda-1.1.9/contrib/dot-tmda/lists/blacklist
-------------------------------------
  - How do empty documents make sense?

* User home directory
-------------------------------------
E: tmda-ofmipd use-tmp-in-%pre
-------------------------------------
> (%pre creates user with /var/tmp as home 
> directory - %pre does not use /tmp)
  Usually this should be %{_sysconfdir}/%{name} or something
  else (see xorg-x11-xfs or ntp, for example)

*  userdel, groupdel...
-------------------------------------
  /usr/sbin/userdel ofmipd >/dev/null 2>&1 || :
  /usr/sbin/groupdel ofmipd >/dev/null 2>&1 || :
-------------------------------------
  - Still under discussion, however, as far as I know
    current Fedora policy is that "some dangerous commands
    like userdel or so should not automatically done and
    should executed by sysadmin with care".

* init script recording
-------------------------------------
W: tmda-ofmipd service-default-enabled /etc/rc.d/init.d/tofmipd
-------------------------------------
   Well, if you don't have a strong reason you want to enable
   tofmipd daemon by default, please the line
-------------------------------------
# chkconfig: 2345 87 13
-------------------------------------
   in %{_initrddir}/tofmipd to
-------------------------------------
# chkconfig: - 87 13
-------------------------------------

* init daemon reload
-------------------------------------
W: tmda-ofmipd no-reload-entry /etc/rc.d/init.d/tofmipd
-------------------------------------
  - Just change
-------------------------------------
  restart)
-------------------------------------
    in %{_initrddir}/tofmipd to
-------------------------------------
  restart|reload)
-------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.