[Bug 226002] Merge Review: libevent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: libevent


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226002


jima at beer.tclug.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jima at beer.tclug.org         |steved at redhat.com
               Flag|fedora-review?              |fedora-review-




------- Additional Comments From jima at beer.tclug.org  2007-02-09 11:28 EST -------
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
6cc776458ecaf9247550863702a44d7c  libevent-1.1a.tar.gz
6cc776458ecaf9247550863702a44d7c  libevent-1.1a.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
See below - Should have dist tag
See below - Should package latest version
1 bug - check for outstanding bugs on package.

Issues:

1. rpmlint says:

W: libevent incoherent-version-in-changelog control 1.1a-3.2.1

I'd recommend fixing the broken changelog entry from Jesse Keating's
bump-n-build script.  (Seconded by Jesse.)

2. Dist tag

Appending "%{?dist}" to the Release field is recommended.  Not a
blocker, but it'd be nice.

3. Not latest version

Upstream web site indicates 1.2a is the latest version (released
2006-12-02).  Please evaluate as to whether upgrading might be for the
best.

4. Bugs open:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204990


If you can address the above, I don't see any reason why libevent can't
be approved for merging.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.