[Bug 227631] Review Request: autofs - A tool for automatically mounting and unmounting filesystems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: autofs - A tool for automatically mounting and unmounting filesystems


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227631





------- Additional Comments From ikent at redhat.com  2007-02-10 00:31 EST -------
(In reply to comment #10)
> (In reply to comment #4)
> > (In reply to comment #1)
> > > 
> > > - rpmlint checks return:
> > > 
> > > W: autofs no-url-tag
> > > 
> > > Is there any?
> > 
> > Not really.
> > 
> > I registered autofs.net and started a wiki (wiki.autofs.net)
> > but it needs quite a bit of care and attention. We could use
> > it anyway. Have a look and see what you think.
>  
> I would list it.

Done.

> 
> > > 
> > > W: autofs unversioned-explicit-obsoletes autofs-ldap
> > > The specfile contains an unversioned Obsoletes: token, which will match all
> > > older, equal and newer versions of the obsoleted thing.  This may cause update
> > > problems, restrict future package/provides naming, and may match something it
> > > was originally not inteded to match -- make the Obsoletes versioned if
> > > possible.
> > 
> > Not sure but I believe this was added when going from
> > autofs version 3 to autofs version 4 and all versions
> > of autofs-ldap needed to be obsoleted. Probably good
> > to keep this.
>  
> This seems to have happened in the RH6.2/7.0 time frame (~autofs 3.1.5/6), and
> I'd would argue that it's long past its usefulness.  

I would argue the opposite, but no matter.

> 
> It also triggers:
> 
> E: autofs obsolete-not-provided autofs-ldap
> The obsoleted package must also be provided to allow clean upgrade paths
> and not to break dependencies.

Also, this doesn't interfere with updates, from what
I've seen.

But I agree there are likely to very few problems as a
result of removing it so I've done so.

> 
> Other rpmlint:
> 
> W: autofs conffile-without-noreplace-flag /etc/rc.d/init.d/autofs
> A configuration file is stored in your package without the noreplace flag.
> 
> - Shouldn't be marked as %config.  You could also use the %{_initrd} macro for
> the diretory here and elsewhere in the spec.

Good catch, I didn't think to use the -v flag.
Fixed.

> 
> E: autofs executable-marked-as-config-file /etc/auto.net
> E: autofs executable-marked-as-config-file /etc/auto.smb
> 
> - But these are okay - expected to be modified and not required for operation.

Where did these come from, I didn't see them in the
rpmlint output? Must have an old version.

And yes, I think it would be best to leave these as
they are.

Ian


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.