[Bug 222039] Review Request: ogdi - Open Geographic Datastore Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogdi - Open Geographic Datastore Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-10 02:37 EST -------
Created an attachment (id=147831)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147831&action=view)
Mock build log of ogdi-3.1.5-2.fc7

(In reply to comment #5)
> updated.
> http://openrisc.rdsor.ro/ogdi.spec
> http://openrisc.rdsor.ro/ogdi-3.1.5-2.src.rpm
Mockbuild log of 3.1.5-2 on FC7 i386 attached.

>From a very quick check:
* compiler flags + debuginfo rpm
  - Fedora specific compilation flags are not passed
  - debuginfo rpm is useless because of missing "-g"
    option
* multilib condition
  - ogdi-driversdir.patch includes
-------------------------------------------
+#define MODULES_PATH "/usr/lib/ogdi/"
-------------------------------------------
    This is questionable on x86_64 arch.

* Documentation
  Add more documentation. Especially, Changelog README
  is rather mandatory.

* autotool
  - Please don't use autotool unless it is necessary.

* header file location
  - Please consider to hide header files into
    %{_includedir}/%{name}
  - By the way, ecs_util.h includes the line:
-----------------------------------------------------
    90	#include "projects.h"
-----------------------------------------------------
    However, I cannot find projects.h

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.