[Bug 226496] Merge Review: tn5250

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tn5250


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226496





------- Additional Comments From pertusus at free.fr  2007-02-10 07:46 EST -------
* There are icons directly in %{_datadir}/icons/ they certainly should 
  be below hicolor.

* A .desktop file is missing for xt5250

* -devel should

Requires:  %{name} = %{version}-%{release}

* missing devel dependencies, on openssl-devel and ncurses-devel and
  pkgconfig

* /usr/share/aclocal/ is unowned in devel

* some dependencies are missing for the pre/post/... scripts.

* BuildRoot is wrong

* Prefix: /usr is certainly wrong too.

* Isn't the Requires ncurse automatically handled?

* Is it really necessary to rerun the autotools?

* %{?_smp_mflags} is missing for make

* Requires: xterm missing for xt5250

* rpmlint will still say
W: tn5250 macro-in-%changelog post
W: tn5250 mixed-use-of-spaces-and-tabs (spaces: line 70, tab: line 1)
W: tn5250-devel summary-not-capitalized development tools for the 5250 protocol.
W: tn5250-devel summary-ended-with-dot development tools for the 5250 protocol.

Suggestions:

* The %files section is certainly over-complicated.

* I would personally have removed the -f from rm, such that it fails
  whenever the target file doesn't exist anymore.

* It is better to add a -p to install calls to keep timestamps, and
  also providing -m xxx for the permissions is relevant.

* add a -b to %patches such that it is easy for other contributors
  to modify and rerun gendiff.

* use %_dist in release

* remove the static libs, adding --disable-static to %configure
  should certainly be enough.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.