[Bug 222039] Review Request: ogdi - Open Geographic Datastore Interface

bugzilla at redhat.com bugzilla at redhat.com
Sun Feb 11 03:36:30 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogdi - Open Geographic Datastore Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039





------- Additional Comments From cbalint at redhat.com  2007-02-10 22:36 EST -------
(In reply to comment #18)
> The .pc changes are wrong. Here is something that seems to
> be right to me:
> 
> Libs.private: -lproj -lexpat -lz

added.
sorry was confused when told me first.

> 
> 
> libecs_tcl.so.1 is still in the main package. Maybe you could avoid that
> by having in %files, instead of %{_libdir}/lib[^l]*.so.*:
> 
> %{_libdir}/libogdi*.so.*

excluded.
 
> The makefiles should certainly be removed from examples shipped
> in %doc. When doing that, make sure that --short-circuit works.

its done, short-circuiting install works fine, olso build works.

> 
> As a suggestion, the removal of .cvsignore could also be in %setup,
> those files shouldn't have been shipped in the first place.

moved in setup, olso added some tab checking lookups, and UTF8 converters.

> 
> 

i come up later , thinking how to solve soname.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list