[Bug 227198] Review Request: jpgalleg - JPEG library for the Allegro game library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jpgalleg - JPEG library for the Allegro game library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227198


guthrie at counterexample.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guthrie at counterexample.org




------- Additional Comments From guthrie at counterexample.org  2007-02-10 23:35 EST -------
This is my first review, so this is kind of unofficial.  So here goes:

- rpmlint -i is silent on the src.rpm.
- Name of spec file matches name of package which matches base part of source
code name
- License in License tag seems to match the license in the source code, but
would it be possible to be more specific that zlib/libpng?  (zlib has a BSD
license, libpng has an "OSI certified license" that looks kind of BSD-ish.)
- source file matches that given in the URL.
- spec file successfuly builds jpgalleg, jpgalleg-devel, and jpgalleg-debuginfo
RPMS on i386.  (I don't have access to any other architectures.)
- BuildRequires seems good.
- calls ldconfig in %post and %postun as it should.
- premissions look good.
- Requires: for the -devel subpackage look good.

I haven't verified that it builds in mock yet, but everything else except for
the license issue above looks quite good.  Even the license thing is minor.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.