[Bug 225522] Review Request: cinepaint - CinePaint is a tool for manipulating images

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cinepaint - CinePaint is a tool for manipulating images


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225522





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-02-11 03:06 EST -------
Created an attachment (id=147846)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=147846&action=view)
mock build log of  cinepaint-0.21.2-1.fc7

mockbuild of 0.21.2 failed on FC-7 i386.

A quick note:
* Please check BuildRequires
  - Does this need java (libgcj)?
  - Is this package gtk+ or gtk2? i.e. Using both
    glib2-devel and gtk+-devel is quite questionable.

* For desktop:
  - Category "X-Fedora" is deprecated and should be
    removed.

* File entry
------------------------------------
%{_datadir}/%{name}/%{cinever}/gimprc
%{_datadir}/%{name}/%{cinever}/gimprc_user
....... (and so on)
------------------------------------
  - ... %{_datadir}/%{name} is not owned by any
    package.
  - By the way, why don't you just write
-------------------------------------
%{_datadir}/%{name}/
-------------------------------------
    ?
   - Same for 
--------------------------------------
%{_libdir}/cinepaint/%{cinever}
%dir %{_libdir}/cinepaint
--------------------------------------
     This description can be unified.

* pkgconfig .pc files
  - Well, the description of .pc file cinepaint-gtk.pc
    is not on standard.
    Fix this file by using "Requires:"	properly.
  - And this .pc file means that -devel package should need
    some packages as Requires.

* automake requirement
---------------------------------------------
%{_datadir}/aclocal/cinepaint.m4
---------------------------------------------
  - This file should be -devel package
  - And current fedora standard is that this file adds
    "automake" to Requires (not BuildRequires)

* python sitelib <-> sitearch
  - Why do these both directories needed?
    * For i386/ppc, these are same
    * For x86_64, these differ, and usually only one directory
      of the two should be used, not both.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.