[Bug 222039] Review Request: ogdi - Open Geographic Datastore Interface

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 12 12:34:48 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ogdi - Open Geographic Datastore Interface


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222039





------- Additional Comments From pertusus at free.fr  2007-02-12 07:34 EST -------
(In reply to comment #24)
> preliminary update.
> Spec: http://openrisc.rdsor.ro/ogdi.spec
> SRPMS: http://openrisc.rdsor.ro/ogdi-3.1.5-5.src.rpm

it is
http://openrisc.rdsor.ro/ogdi-3.1.5-6.src.rpm

> Preliminary fix:
> a) zero compile warrn
> b) do the right thing with dlopen. (re-work)
> c) fix --target=i386 build.
> d) test program functionality.
> 
> Working with maintainer to get in:
> 0) cleanup all sources: a. UTF8 b. remuve junks c. dos2unix d. chmod fix.

Having stuff not in UTF-8 isn't a bug. It is upstream choice. Same
may be true or not for dos2unix, it depends on the precise situation.

> 1) cleanup patch
> 2) soname patch (i proposed to him a final one)
> 3) dlopen patch (reworked, and proposed final one)
> 4) hide plugins by default into  /usr/lib/ogdi folder.

You should also give them the pkgconfig file. For that you could send them
A file named ogdi.pc.in with something along:
 
prefix=@prefix@
exec_prefix=@prefix@
libdir=@libdir@
includedir=@includedir@

Name: @PACKAGE@
Description: Open Geographic Datastore Interface
Version: @VERSION@
Cflags: -I${includedir}/@PACKAGE@
Libs: -L${libdir} -logdi
Libs.private: -lproj -lexpat -lz


And you should add it to the files generatd by configure.ac,
and also maybe add a installation target, or let it to the
packager/end user. 

Also you could also propose the projects include patch to upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list