[Bug 227057] Review Request: gnu-regexp-1.1.4-10jpp - Java NFA regular expression engine implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnu-regexp-1.1.4-10jpp - Java NFA regular expression engine implementation


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227057


jjohnstn at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review-




------- Additional Comments From jjohnstn at redhat.com  2007-02-12 10:50 EST -------
Review Comments

- result of rpmlint
W: gnu-regexp non-standard-group Development/Libraries/Java
E: gnu-regexp tag-not-utf8 %changelog
E: gnu-regexp unknown-key GPG#c431416d
E: gnu-regexp non-utf8-spec-file gnu-regexp.spec
W: gnu-regexp unversioned-explicit-provides gnu.regexp
W: gnu-regexp unversioned-explicit-obsoletes gnu.regexp
W: gnu-regexp unversioned-explicit-provides gnu.regexp-demo
W: gnu-regexp unversioned-explicit-obsoletes gnu.regexp-demo
W: gnu-regexp unversioned-explicit-provides gnu.regexp-javadoc
W: gnu-regexp unversioned-explicit-obsoletes gnu.regexp-javadoc
W: gnu-regexp mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 48)

- Spec file name should be gnu-regexp.spec
- release should be of form: Xjpp.Y%{?dist} where only X and Y are variables
  X=upstream number and Y is local number starting with 1
- preferred buildroot is:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
- it would nice in the future to add gcj support (at that time, remove the
Buildarch: noarch statement

** rpmlint on binary rpms

[jjohnstn at vermillion noarch]$ rpmlint gnu-regexp-1.1.4-10jpp.noarch.rpm 
W: gnu-regexp non-standard-group Development/Libraries/Java
E: gnu-regexp tag-not-utf8 %changelog
[jjohnstn at vermillion noarch]$ rpmlint gnu-regexp-demo-1.1.4-10jpp.noarch.rpm 
W: gnu-regexp-demo non-standard-group Development/Libraries/Java
E: gnu-regexp-demo tag-not-utf8 %changelog
W: gnu-regexp-demo no-documentation
[jjohnstn at vermillion noarch]$ rpmlint gnu-regexp-javadoc-1.1.4-10jpp.noarch.rpm 
W: gnu-regexp-javadoc non-standard-group Development/Documentation
E: gnu-regexp-javadoc tag-not-utf8 %changelog
W: gnu-regexp-javadoc dangerous-command-in-%post rm
W: gnu-regexp-javadoc dangerous-command-in-%postun rm



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.