[Bug 227046] Review Request: classpathx-jaxp-1.0-0.beta1.10jpp - Java XML parser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: classpathx-jaxp-1.0-0.beta1.10jpp - Java XML parser


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227046


jjohnstn at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jjohnstn at redhat.com         |fitzsim at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From jjohnstn at redhat.com  2007-02-12 12:24 EST -------
review below: elements with X need to be dealt with

MUST:
X specfile should be %{name}.spec
   * rename spec file to classpathx-jaxp.spec
X License should be just GPL
X correct buildroot
 - should be:
   %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
X rpmlint on <this package>.srpm gives no output

W: classpathx-jaxp non-standard-group Text Processing/Markup/XML
W: classpathx-jaxp invalid-license GPL with library exception
E: classpathx-jaxp unknown-key GPG#c431416d
W: classpathx-jaxp unversioned-explicit-provides jaxp_parser_impl
E: classpathx-jaxp configure-without-libdir-spec
W: classpathx-jaxp mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 76

X Vendor tag should not be used
X package successfully compiles and builds on at least x86
 - Build fails because gnu.xml.aelfred2 not found
  - gnu.xml.aelfred2 needs to be a BuildRequires
X - Summary(fr) should not be included
  - this can be in localized version
X verify the final provides and requires of the binary RPMs
  - could not build as gnu.xml.aelfred2 is not a Fedora package
X run rpmlint on the binary RPMs
  - could not do as build failed

SHOULD:
X package should build on i386
  - not yet
* package should build in mock


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.