[Bug 215659] Review Request: python-daap - A DAAP client implemented in Python
bugzilla at redhat.com
bugzilla at redhat.com
Mon Feb 12 19:24:43 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-daap - A DAAP client implemented in Python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215659
------- Additional Comments From matthias at rpmforge.net 2007-02-12 14:24 EST -------
Too bad for the license, then...
Anyway, two more quickies :
- The consensus would seem to be to remove the leading "A " from the summary
- The "cp" for SOURCE1 is wrong, as a bad umask can lead to wrong file modes,
which is known to have happened in the build system, use "install -m 0644" instead
The rest looks quite alright to me. Jochen : Please review ASAP or let me know
if you want me to pick this one up.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list