[Bug 227112] Review Request: relaxngDatatype-1.0-3jpp - RELAX NG Datatype API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: relaxngDatatype-1.0-3jpp - RELAX NG Datatype API


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227112


overholt at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|overholt at redhat.com         |nsantos at redhat.com
               Flag|                            |fedora-review-




------- Additional Comments From overholt at redhat.com  2007-02-12 18:27 EST -------
Updated spec and SRPM here:

http://overholt.ca/fedora/relaxngDatatype.spec
http://overholt.ca/fedora/relaxngDatatype-1.0-3jpp.1.src.rpm

(In reply to comment #1)
> ?? * is it legal for Fedora to distribute this?
> ?? - OSI-approved

It's BSD licensed so it's fine.

> ?? * verify source and patches (md5sum matches upstream, know what the patches do)

I've verified that the upstream zip matches the one in the SRPM.

> NA * if %{?dist} is used, it should be in that form

We should use %{?dist}.  I've fixed this.

> NO * rpmlint on <this package>.srpm gives no output
> $ rpmlint relaxngDatatype-1.0-3jpp.src.rpm 
> W: relaxngDatatype non-standard-group Development/Libraries/Java

This is fine.

> E: relaxngDatatype unknown-key GPG#c431416d

This is just the JPackage GPG key.

> W: relaxngDatatype unversioned-explicit-obsoletes msv

I've added a <= %{version}.

> W: relaxngDatatype mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 50)

I fixed this.

> NO * Vendor tag should not be used

Fixed.  Removed Distribution as well.

> NO * description expands upon summary

Fixed.

> NO * use macros appropriately and consistently
> %install
> rm -rf $RPM_BUILD_ROOT
> install -Dpm 644 %{name}.jar \
>   $RPM_BUILD_ROOT%{_javadir}/%{name}-%{version}.jar

I think this is fine.

> NO * run rpmlint on the binary RPMs
> 
> $ rpmlint relaxngDatatype-1.0-3jpp.noarch.rpm 
> W: relaxngDatatype non-standard-group Development/Libraries/Java

This is fine.

> E: relaxngDatatype obsolete-not-provided msv

See above.

> W: relaxngDatatype wrong-file-end-of-line-encoding
> /usr/share/doc/relaxngDatatype-1.0/copying.txt

Fixed.  I also fixed it for the javadoc-generated HTML files and added a patch
to compress the jar to supress an rpmlint warning.

This package should be gcj-ified at some point.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.