[Bug 226666] Merge Review: yum

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: yum


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226666





------- Additional Comments From tla at rasmil.dk  2007-02-13 08:23 EST -------
Must :
OK - spec filename is %{name}.spec
OK - source match upstream md5sum
     CVS:          6e6953f92531aa0f9074199f2925d22a  yum-3.1.1.tar.gz
     Upstream :	   6e6953f92531aa0f9074199f2925d22a  yum-3.1.1.tar.gz
OK - Package naming 
OK - Spec in American English and legible
OK - License : GPL
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - License file (COPYING) is included in %doc
   - Package compiles and builds on at least one arch.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package owns all the directories it creates.
FAIL - Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Comments:
 * Source0 should end with %{name}-%{version}, not yum-%{version}	
 * Requires: python (Upstream spec has Requires: python >= 2.4)
 * Requires: rpm >= 0:4.1.1 ( Upstream spec has Requires:  rpm >= 0:4.4.2)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.