[Bug 226133] Merge Review: mc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: mc


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226133





------- Additional Comments From dan at danny.cz  2007-02-13 09:39 EST -------
The full review is here and see the output of rpmlint at the end

OK	source files match upstream:
	    740d8b17463002c5bb3915841eb9abf936377c50375b410cb5d0640900ede8f3 
mc-2007-01-24-03.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (i386).
OK	debuginfo package looks complete.
OK	final provides and requires looks sane
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK?	file permissions are appropriate.
OK	no scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.


BAD	rpmlint is not silent.

I: mc-debuginfo checking
I: mc checking
W: mc incoherent-version-in-changelog 4.6.1a-42 1:4.6.1a-42.20070124cvs.fc7
    minor :-)

W: mc conffile-without-noreplace-flag /etc/mc/cedit.menu
W: mc conffile-without-noreplace-flag /etc/mc/edit.indent.rc
W: mc conffile-without-noreplace-flag /etc/mc/edit.spell.rc
W: mc conffile-without-noreplace-flag /etc/mc/extfs/extfs.ini
W: mc conffile-without-noreplace-flag /etc/mc/extfs/sfs.ini
W: mc conffile-without-noreplace-flag /etc/mc/mc.charsets
W: mc conffile-without-noreplace-flag /etc/mc/mc.ext
W: mc conffile-without-noreplace-flag /etc/mc/mc.lib
W: mc conffile-without-noreplace-flag /etc/mc/mc.menu
W: mc conffile-without-noreplace-flag /etc/mc/syntax/Syntax
    at least mc.ext, mc.menu should be "noreplace", maybe all

W: mc conffile-without-noreplace-flag /etc/profile.d/mc.csh
W: mc conffile-without-noreplace-flag /etc/profile.d/mc.sh

E: mc script-without-shebang /usr/share/mc/bin/mc-wrapper.sh
E: mc script-without-shebang /usr/share/mc/bin/mc-wrapper.csh

E: mc executable-marked-as-config-file /etc/profile.d/mc.sh
E: mc executable-sourced-script /etc/profile.d/mc.sh 0755
E: mc non-executable-script /etc/mc/edit.spell.rc 0644
E: mc script-without-shebang /usr/share/mc/bin/mc.sh
E: mc script-without-shebang /usr/share/mc/bin/mc.csh

E: mc non-standard-uid /usr/libexec/mc/cons.saver vcsa
E: mc setuid-binary /usr/libexec/mc/cons.saver vcsa 04711
E: mc non-standard-executable-perm /usr/libexec/mc/cons.saver 04711
E: mc non-standard-executable-perm /usr/libexec/mc/cons.saver 04711

E: mc executable-marked-as-config-file /etc/profile.d/mc.csh
E: mc executable-sourced-script /etc/profile.d/mc.csh 0755
E: mc non-executable-script /etc/mc/edit.indent.rc 0644

Can you give some explanation for the issues above? I don't think they are real
blockers, but would like to read your opinion.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.