[Bug 227117] Review Request: tagsoup-1.0.1-1jpp - A SAX-compliant parser written in Java that parses HTML as it is found in the wild: nasty and brutish

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tagsoup-1.0.1-1jpp - A SAX-compliant parser written in Java that parses HTML as it is found in the wild: nasty and brutish


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227117


pcheung at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pcheung at redhat.com          |vivekl at redhat.com
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From pcheung at redhat.com  2007-02-13 13:52 EST -------
(In reply to comment #5)
> (In reply to comment #4)
> > I'm still getting this on the srpm:
> > W: tagsoup mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 54) (this is
> > on the gcj requires)
> Oops, fixed...
> 
Great
> > and this on the binary rpm:
> > W: tagsoup incoherent-version-in-changelog 0:1.0.1-1jpp.1.fc7 0:1.0.1-1jpp.1
> >                                                                                 
This is fixed too

> > Buildroot should be:
> > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n
> > (-root missing)
> >                                                                                 
> Thanks
> 
Sweet
> > Also, since gcj support is added, we need to have %define _with_gcj_support 1.
> > 
> Fixed.
> The updated package is available at the same URL
> 
> 
rpmlint on the rpms built in mock:
[pcheung at to-fcjpp1 ~]$ rpmlint
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/tagsoup-*
W: tagsoup non-standard-group Text Processing/Markup/XML
W: tagsoup non-standard-group Text Processing/Markup/XML
W: tagsoup-javadoc non-standard-group Development/Documentation


APPROVED. Thanks!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.