[Bug 227079] Review Request: maven2-common-poms-1.0-3jpp - Common poms for maven2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: maven2-common-poms-1.0-3jpp - Common poms for maven2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227079


overholt at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|overholt at redhat.com         |dbhole at redhat.com




------- Additional Comments From overholt at redhat.com  2007-02-13 15:10 EST -------
(In reply to comment #2)
> X verify source and patches
>  . we really need to host the source tarball somewhere other than just in the
>    SRPM.  Even just on your people page is fine.  The XML file as well.

The md5sums now match.

X Please change the Source0 line to the full URL

> X skim the summary and description for typos, etc.
>  . "maven2 dependent" -> "maven2-dependent"

Verified, thanks.

> X license text included in package and marked with %doc
>  . since you're maintaining the source, can you include the ASL text?

Can we do this?

> X BuildRequires are proper
>  . why the Requires(postun) on jpackage-utils?  There's no %postun.

Verified.

> X package should include license text in the package and mark it with %doc

This is the only thing remaining.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.