[Bug 228544] Review Request: keepalived - HA monitor built upon LVS, VRRP and services poller

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: keepalived - HA monitor built upon LVS, VRRP and services poller


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228544


dan at danny.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |dan at danny.cz
OtherBugsDependingO|163776                      |163779
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From dan at danny.cz  2007-02-13 15:57 EST -------
Full review is here:

OK	source files match upstream:
	    2545bd681580a97f9c5c9bbe6fe2f8a91988d0c5f063bba048148b52ccde2568 
keepalived-1.1.13.tar.gz
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible. License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
OK	compiler flags are appropriate.
OK	%clean is present.
OK	debuginfo package looks complete.
OK	rpmlint is silent.
BAD	final provides and requires don´t look sane:
		the scriptlet Requires are missing

Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig
Requires(preun): /sbin/service

OK	%check is present and all tests pass:
OK	no shared libraries are added to the regular linker search paths.
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	scriptlets are present and are sane.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	no pkgconfig files.
OK	no libtool .la droppings.
OK	not a GUI app.

after you will add the scriptlet Requires, then the package is APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.