[Bug 227091] Review Request: objectweb-anttask-1.3.2-1jpp - ObjectWeb Ant task

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: objectweb-anttask-1.3.2-1jpp - ObjectWeb Ant task


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227091


pcheung at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pcheung at redhat.com          |tbento at redhat.com
               Flag|fedora-review-              |fedora-review+




------- Additional Comments From pcheung at redhat.com  2007-02-13 16:20 EST -------
(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > MUST:
> > The provides should be (without <):
> > Provides:         owanttask = %{epoch}:%{version}-%{release}
> 
> Fixed.
Great!
> 
> > Since with_bootstrap option is added, you'll need to define a value for the
> > variable.
> > I'll check the following when the spec file is updated, and rpms rebuilt from
> > that spec file.
> 
> Fixed.  Defined it to 1.

It's now set to 0 for bootstrapping build for the first time.

I've built it in mock successfully, rpmlint on the current src and binary rpms:
[pcheung at to-fcjpp1 ~]$ rpmlint
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/objectweb-anttask-1.3.2-1jpp.1.fc7.noarch.rpm
/var/lib/mock/fedora-development-x86_64-core-pcheung/result/objectweb-anttask-javadoc-1.3.2-1jpp.1.fc7.noarch.rpm
 /var/lib/mock/fedora-development-x86_64-core-pcheung/result/objectweb-anttask-1.3.2-1jpp.1.fc7.src.rpm
W: objectweb-anttask non-standard-group Development/Java
W: objectweb-anttask-javadoc non-standard-group Development/Documentation
W: objectweb-anttask non-standard-group Development/Java


APPROVED. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.