[Bug 227048] Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dom2-core-tests-0.0.1-0.20040405.1jpp - DOM Conformance Test Suite


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=227048


tbento at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|tbento at redhat.com           |vivekl at redhat.com




------- Additional Comments From tbento at redhat.com  2007-02-13 17:16 EST -------
(In reply to comment #2)
> (In reply to comment #1)
> > ==============================
> > RPMLINT OUTPUT FOR SOURCE RPM:
> > ==============================
> > 
> > W: dom2-core-tests non-standard-group Text Processing/Markup/XML
> Ignoring since groups can apparently be arbitrary
> 
> > W: dom2-core-tests invalid-license W3C Software License
> http://www.opensource.org/licenses/W3C.php suggests license is OSI approved
> Using W3C License in this field
> 
> > W: dom2-core-tests rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
> Removed
> 
> > W: dom2-core-tests mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 42)
> Fixed
> 
> > W: dom2-core-tests class-path-in-manifest /dom2-core-tests-20040405.jar
> Ignoring since these are mandated by package build process
> 
> > ===============================
> > RPMLINT OUTPUT FOR BINARY RPMS:
> > ===============================
> > 
> > dom2-core-tests-0.0.1-0.20040405.1jpp.noarch.rpm:
> > -------------------------------------------------
> > W: dom2-core-tests non-standard-group Text Processing/Markup/XML
> Ignoring since groups can apparently be arbitrary
> > W: dom2-core-tests invalid license W3C Software license
> See above
> > W: dom2-core-tests no-documentation
> There doesnt seem to be anything in the build directory to use for doc, can we
> waive this? 
> 
> > dom2-core-tests-javadoc-00,01-0.20040405-1jpp.noarch.rpm:
> > ---------------------------------------------------------
> > W: dom2-core-tests-javadoc non-standard-group Development/Documentation
> Ignore as above
> 
> > W: dom2-core-tests-javadoc invalid-license W3C Software License
> Changed to W3C License
> 
> > W: dom2-core-tests-javadoc dangerous-command-in-%post rm
> > w: dom2-core-tests-javadoc dangerous-command-in-%postun rm
> Removed the use of post and postun scripts
> 
> > - Fix %Release tag.
> Fixed
> > 
> > - Remove %Vendor and &Distribution.
> > 
> > - Add "-%(%{__id_u} -n)" to the end of %BuildRoot.
> >
> > - In the future, when adding gcj support, remove %BuildArch.
> >
> Fixed
>  
> > - Change the changelog entry format.  Ralph's email should read
> > "<r.apel at r-apel.de>".
> > 
> I think the guidelines are more particular about the location of ENVR in the
> changelog.

Great.  I think there may be a minor bug in %changelog because rpmlint now
generates the following warning when run on
dom2-core-tests-0.0.1-0.1.20040405.1jpp.1.i386.rpm:
W: dom2-core-tests incoherent-version-in-changelog
1:0.0.1-0.1.20040405.1jpp.1.fc7 1:0.0.1-0.1.20040405.1jpp.1
Could you have a look at this?

Also, there seem to be a couple of lines with more than 80 characters.  I didn't
know this was a must, which is why I didn't mention anything previously.  Could
you also have a look at that?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.