[Bug 228481] Review Request: hunspell-hu - Hungarian hunspell dictionaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hunspell-hu - Hungarian hunspell dictionaries


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228481


wolfy at nobugconsulting.ro changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
OtherBugsDependingO|163776                      |163779
              nThis|                            |
               Flag|                            |fedora-review+




------- Additional Comments From wolfy at nobugconsulting.ro  2007-02-13 18:30 EST -------
GOOD

- package meets naming guidelines
- package meets packaging guidelines 
- spec file legible, in am. english
- source matches upstream , sha1sum 
034cafefbb6d912c28e15d6fe45e0dbe01e16fbf  hu_HU_comb.zip
- the package builds in mock for devel/x86_64, generates a noarch (which is
consistent with the fact that basically it includes only 3 text files)
- there are only 2 files (word lists) + a short doc with instructions and
license clearance, so no .la, .pc, static files
- no missing BR
- no locales
- not relocatable
- owns all files/directories that it creates, does not take ownership of other
files/dirs
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- rpmlint output is silent
- code, not content
- no need for -docs as the only doc is just a 3 liner text file
- nothing in %doc affects runtime
- no need for .desktop file 

NEEDFIX - the license LGPL stated in the tag is NOT the same as the web site
says (GPL, see
http://ftp.services.openoffice.org/pub/OpenOffice.org/contrib/dictionaries/README_hu_HU.txt).

APPROVED, but please fix the license tag before importing.
Please also ask upstream to include the license file in the archive


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.