[Bug 225295] Merge Review: autoconf213

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: autoconf213


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225295


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2007-02-13 18:34 EST -------
Issues:

* Builroot is not right

* In general textutils shouldn't be in Requires. Which program is 
  it for?

* info files should be compressed automatically

* remove summary end dot

* install-info scriptlets are missing

* gawk and perl seems to be BuildRequires. perl may be omitted.

suggestions:

* the indenting of the beginning of the spec looks bad because there 
  are spaces and tabs.

* I think that BuildArch is prefered over BuildArchitectures

* use %defattr(-,root,root,-) instead of %defattr(-,root,root) for 
  consistency

* having a / at the end of a directory in %files shows visually that
  it is indeed a directory:
%{_datadir}/autoconf-%{version}/

* maybe the testsuite could be run?

Remark:

* make install DESTDIR=.. is preferred over %makeinstall, but here
  it seems that there is no support for DESTDIR.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.